Fehler in /admins

Allrounder18 · 16. Februar 2019

Hallo!

Bei meinem /admins wird nicht angezeigt ob der User Online ist sobald er online ist.

Code

public AdminList(playerid)
{
    new string[512],header[2000],adminrang,name[MAX_PLAYER_NAME],onlinestatus[500];
    new rows;
    cache_get_row_count(rows);
    for(new i=0;i<rows;i++)
    {
        cache_get_value_name_int(i,"Admin",adminrang);
        cache_get_value_name(i,"Name",name,MAX_PLAYER_NAME);
        if(adminrang > 1 && adminrang < 8)
        {  
        	GetPlayerStatus(name,onlinestatus);
            format(string, sizeof(string), "%s\n%s\t%s\t%s",string, GetAdminName(adminrang), name,onlinestatus);
            format(header,sizeof(header),"Rang\tName\tOnlinestatus\n%s",string);
        }
    }
    ShowPlayerDialog(playerid, DIALOG_ADMINS, DIALOG_STYLE_TABLIST_HEADERS, "test - Team",header,"Abbrechen","");
    return 1;
}

Alles anzeigen

Was ist hier falsch?

Code

stock GetPlayerStatus(const name[],out[])
{
    static const status[][] = {"{FF0000}Offline","{40FF00}Online","{FF0048}AFK"};


    for(new i=GetPlayerPoolSize(),n[MAX_PLAYER_NAME]; i!=-1; i--)
    {
        if(!IsPlayerNPC(i) || !GetPlayerName(i,n,MAX_PLAYER_NAME) || strcmp(name,n) != 0) continue;
        if(SpielerDaten[i][player_AdminDienst])
        {
        	return format(out, 32, status[1]);
        }	
        return format(out,32,status[IsPlayerAFK(i) ? 2 : 1]);
    }
    return format(out,32,status[0]);
}

Alles anzeigen

reaL. · 16. Februar 2019

Du kannst es einfach so machen

Code

format(string, sizeof(string), "%s\n%s\t%s\t%s",string, GetAdminName(adminrang), name, (IsPlayerConnected(playerid))?("Online"):("Offline"));

Allrounder18 · 16. Februar 2019

Code

public AdminList(playerid)
{
    new string[512],header[2000],adminrang,name[MAX_PLAYER_NAME];
    new rows;
    cache_get_row_count(rows);
    for(new i=0;i<rows;i++)
    {
        cache_get_value_name_int(i,"Admin",adminrang);
        cache_get_value_name(i,"Name",name,MAX_PLAYER_NAME);
        if(adminrang > 1 && adminrang < 8)
        {  
            format(string, sizeof(string), "%s\n%s\t%s\t%s",string, GetAdminName(adminrang), name, (IsPlayerConnected(playerid))?("{40FF00}Online"):("{FF0000}Offline"));
        	format(header,sizeof(header),"Rang\tName\tOnlinestatus\n%s",string);
        }
    }
    ShowPlayerDialog(playerid, DIALOG_ADMINS, DIALOG_STYLE_TABLIST_HEADERS, "test - Team",header,"Abbrechen","");
    return 1;
}

Alles anzeigen

Jetzt werden alle Spieler als online angezeigt, obwohl nur einr online ist.

reaL. · 16. Februar 2019

Code

public AdminList(playerid)
{
    new string[512],header[2000],adminrang,name[MAX_PLAYER_NAME],pID;
    new rows;
    cache_get_row_count(rows);
    for(new i=0;i<rows;i++)
    {
        cache_get_value_name_int(i,"Admin",adminrang);
        cache_get_value_name(i,"Name",name,MAX_PLAYER_NAME);
        pID = GetPlayerIdFromName(Name);
        if(adminrang > 1 && adminrang < 8)
        {
            format(string, sizeof(string), "%s\n%s\t%s\t%s",string, GetAdminName(adminrang), name, (IsPlayerConnected(pID))?("{40FF00}Online"):("{FF0000}Offline"));
        	format(header,sizeof(header),"Rang\tName\tOnlinestatus\n%s",string);
        }
    }
    ShowPlayerDialog(playerid, DIALOG_ADMINS, DIALOG_STYLE_TABLIST_HEADERS, "test - Team",header,"Abbrechen","");
    return 1;
}

Alles anzeigen

Code

stock GetPlayerIdFromName(playername[])
{
  for(new i = 0; i <= MAX_PLAYERS; i++)
  {
    if(IsPlayerConnected(i))
    {
      new playername2[MAX_PLAYER_NAME];
      GetPlayerName(i, playername2, sizeof(playername2));
      if(strcmp(playername2, playername, true, strlen(playername)) == 0)
      {
        return i;
      }
    }
  }
  return INVALID_PLAYER_ID;
}

Alles anzeigen

Allrounder18 · 16. Februar 2019

Code

public AdminList(playerid)
{
    new string[1000],header[1001],adminrang,name[MAX_PLAYER_NAME],pID;
    new rows;
    cache_get_row_count(rows);
    for(new i=0;i<rows;i++)
    {
        cache_get_value_name_int(i,"Admin",adminrang);
        cache_get_value_name(i,"Name",name,255);
        pID = GetPlayerIdFromName(name);
        if(adminrang > 2 && adminrang < 8)
        {  
            format(string, sizeof(string), "%s\n%s\t%s\t%s",string, GetAdminName(adminrang), name, GetPlayerStatus(pID));
        	format(header,sizeof(header),"Rang\tName\tOnlinestatus\n%s",string);
        	print(header);
        }
    }
    ShowPlayerDialog(playerid, DIALOG_ADMINS, DIALOG_STYLE_TABLIST_HEADERS, "{FF0000}Austrian Roleplay {FFFFFF}- Team",header,"Abbrechen","");
    return 1;
}

Alles anzeigen

Code

stock GetPlayerStatus(playerid)
{
	new string[500];
    if(SpielerDaten[playerid][player_Eingeloggt])
    {
    	if(IsPlayerAFK(playerid)) { format(string, 32, "{FF0048}AFK"); return string;} 
    	if(SpielerDaten[playerid][player_AdminDienst])
        {
        	format(string, 32, "Im Dienst");
        	return string;
        }
        format(string, 32, "{40FF00}Online");	
        return string;
    }	
    else
    {
    	format(string,32,"{FF0000}Offline");
    	return string; 
    }	
}

Alles anzeigen

Momentan wirft das Script folgende Errors:
[17:52:47] [debug] Run time error 4: "Array index out of bounds"
[17:52:47] [debug] Attempted to read/write array element at index 65535 in array of size 1000
[17:52:47] [debug] AMX backtrace:
[17:52:47] [debug] #0 0000e944 in ?? (65535) in arp.amx
[17:52:47] [debug] #1 000108c0 in public AdminList (0) in arp.amx

Edit: Hab mal mit -d3 compiled, jetzt komt folgendes
[18:50:11] [debug] Run time error 4: "Array index out of bounds"
[18:50:11] [debug] Attempted to read/write array element at index 65535 in array of size 1000
[18:50:11] [debug] AMX backtrace:
[18:50:11] [debug] #0 00011d10 in GetPlayerStatus (playerid=65535) at C:\Users\Alexander\Documents\meinserver\ARP2.0\pawno\include\../include/core/stocks.inc:671
[18:50:11] [debug] #1 0001455c in public AdminList (playerid=0) at C:\Users\Alexander\Documents\meinserver\ARP2.0\pawno\include\../include/core/daten.inc:160

dnlk · 16. Februar 2019

Zitat von Allrounder18
Code
public AdminList(playerid)
{
    new string[1000],header[1001],adminrang,name[MAX_PLAYER_NAME],pID;
    new rows;
    cache_get_row_count(rows);
    for(new i=0;i<rows;i++)
    {
        cache_get_value_name_int(i,"Admin",adminrang);
        cache_get_value_name(i,"Name",name,255);
        pID = GetPlayerIdFromName(name);
        if(adminrang > 2 && adminrang < 8)
        {  
            format(string, sizeof(string), "%s\n%s\t%s\t%s",string, GetAdminName(adminrang), name, GetPlayerStatus(pID));
        	format(header,sizeof(header),"Rang\tName\tOnlinestatus\n%s",string);
        	print(header);
        }
    }
    ShowPlayerDialog(playerid, DIALOG_ADMINS, DIALOG_STYLE_TABLIST_HEADERS, "{FF0000}Austrian Roleplay {FFFFFF}- Team",header,"Abbrechen","");
    return 1;
}
Alles anzeigen
Code
stock GetPlayerStatus(playerid)
{
	new string[500];
    if(SpielerDaten[playerid][player_Eingeloggt])
    {
    	if(IsPlayerAFK(playerid)) { format(string, 32, "{FF0048}AFK"); return string;} 
    	if(SpielerDaten[playerid][player_AdminDienst])
        {
        	format(string, 32, "Im Dienst");
        	return string;
        }
        format(string, 32, "{40FF00}Online");	
        return string;
    }	
    else
    {
    	format(string,32,"{FF0000}Offline");
    	return string; 
    }	
}
Alles anzeigen
Momentan wirft das Script folgende Errors:
[17:52:47] [debug] Run time error 4: "Array index out of bounds"
[17:52:47] [debug] Attempted to read/write array element at index 65535 in array of size 1000
[17:52:47] [debug] AMX backtrace:
[17:52:47] [debug] #0 0000e944 in ?? (65535) in arp.amx
[17:52:47] [debug] #1 000108c0 in public AdminList (0) in arp.amx

Edit: Hab mal mit -d3 compiled, jetzt komt folgendes
[18:50:11] [debug] Run time error 4: "Array index out of bounds"
[18:50:11] [debug] Attempted to read/write array element at index 65535 in array of size 1000
[18:50:11] [debug] AMX backtrace:
[18:50:11] [debug] #0 00011d10 in GetPlayerStatus (playerid=65535) at C:\Users\Alexander\Documents\meinserver\ARP2.0\pawno\include\../include/core/stocks.inc:671
[18:50:11] [debug] #1 0001455c in public AdminList (playerid=0) at C:\Users\Alexander\Documents\meinserver\ARP2.0\pawno\include\../include/core/daten.inc:160
Alles anzeigen

pID = GetPlayerIdFromName(name);
Gibt 65535 (INVALID_PLAYER_ID) zurück wenn der Spieler nicht online ist.
Nach sowas solltest du immer mit IsPlayerConnected überprüfen ob die zurückgegebene ID überhaupt online ist.

Also:

pID = GetPlayerIdFromName(name);
if (!IsPlayerConnected(pID)) continue;

Allrounder18 · 16. Februar 2019

Jetzt wird der Dialog garnicht mehr angezeigt

Code

public AdminList(playerid)
{
    new string[1000],header[1001],adminrang,name[MAX_PLAYER_NAME],pID;
    new rows;
    cache_get_row_count(rows);
    for(new i=0;i<rows;i++)
    {
        cache_get_value_name_int(i,"Admin",adminrang);
        cache_get_value_name(i,"Name",name,255);
        pID = GetPlayerIdFromName(name);
		if(!IsPlayerConnected(pID)) continue;
        if(adminrang > 2 && adminrang < 8)
        {  
            format(string, sizeof(string), "%s\n%s\t%s\t%s",string, GetAdminName(adminrang), name, GetPlayerStatus(pID));
        	format(header,sizeof(header),"Rang\tName\tOnlinestatus\n%s",string);
        }
    }
    ShowPlayerDialog(playerid, DIALOG_ADMINS, DIALOG_STYLE_TABLIST_HEADERS, "{FF0000}Austrian Roleplay {FFFFFF}- Team",header,"Abbrechen","");
    return 1;
}

Alles anzeigen

@Infra

dnlk · 16. Februar 2019

Zeig mal die GetPlayerIdFromName funktion

Allrounder18 · 16. Februar 2019

Code

stock GetPlayerIdFromName(playername[])
{
  for(new i = 0; i <= MAX_PLAYERS; i++)
  {
    if(IsPlayerConnected(i))
    {
      new playername2[MAX_PLAYER_NAME];
      GetPlayerName(i, playername2, sizeof(playername2));
      if(strcmp(playername2, playername, true, strlen(playername)) == 0)
      {
        return i;
      }
    }
  }
  return INVALID_PLAYER_ID;
}

Alles anzeigen

dnlk · 16. Februar 2019

Ich gehe mal davon aus dass du sscanf geladen hast,
Probier das mal mit diesem Code:

GetPlayerIdFromName(const pName[])
{
new playerid = INVALID_PLAYER_ID;
sscanf(pName, "u", playerid);
return playerid;
}

Allrounder18 · 16. Februar 2019

Jetzt werde nur ich angezeigt und alle die offline sind nicht, was aber nicht so sein sollte.

@Infra

dnlk · 16. Februar 2019

Hab deinen Code etwas falsch verstanden,

Nimm in der AdminList funktion das if (!IsPlayerConnected(pID)) continue; wieder raus.

Ersetz bei GetPlayerStatus das if(SpielerDaten[playerid][player_Eingeloggt]) mit if (IsPlayerConnected(playerid) && SpielerDaten[playerid][player_Eingeloggt])

Allrounder18 · 16. Februar 2019

Funktioniert. Aber irgendwie führt er OnPlayerSpawn nicht mehr aus.

Code

public OnUserLogin(playerid)
{
	new rows,string[500];
	cache_get_row_count(rows);
	if(rows == 0)
	{
		format(string,sizeof(string), "Dieses Passwort ist falsch.");
		SendErrorMessage(playerid,string);
		ShowPlayerDialog(playerid, DIALOG_LOGIN, DIALOG_STYLE_PASSWORD, "{FFFFFF}Anmeldung", "{FFFFFF}Um spielen zu können musst du dich einloggen", "{FFFFFF}Einloggen", "{FFFFFF}Abbrechen");
	}
	else
	{
 		cache_get_value_name_int(0, "ID", SpielerDaten[playerid][player_ID]);
        cache_get_value_name_int(0, "Level", SpielerDaten[playerid][player_Level]);
 		cache_get_value_name_int(0, "Euro", SpielerDaten[playerid][player_Euro]);
 		cache_get_value_name_int(0, "Cent", SpielerDaten[playerid][player_Cent]);
 		cache_get_value_name_int(0, "Skin", SpielerDaten[playerid][player_Skin]);
 		cache_get_value_name_int(0, "Admin", SpielerDaten[playerid][player_Admin]);
 		cache_get_value_name_float(0, "SpawnX", SpielerDaten[playerid][player_Spawn][0]);
 		cache_get_value_name_float(0, "SpawnY", SpielerDaten[playerid][player_Spawn][1]);
 		cache_get_value_name_float(0, "SpawnZ", SpielerDaten[playerid][player_Spawn][2]);
 		cache_get_value_name_float(0, "SpawnR", SpielerDaten[playerid][player_Spawn][3]);
 		cache_get_value_name_int(0, "SpawnInt", SpielerDaten[playerid][player_Interior]);
 		cache_get_value_name_int(0, "SpawnWorld", SpielerDaten[playerid][player_World]);
 		cache_get_value_name(0, "RPName",SpielerDaten[playerid][player_RPName],265);
 		HideLoginScreen(playerid);
 		SpielerDaten[playerid][player_Eingeloggt]  = true;
 		SpawnPlayer(playerid);
		format(string,sizeof(string),"{FFFFFF}Willkommen zurück %s {FF0000}[%d]",SpielerDaten[playerid][player_Name],playerid);
		SendClientMessage(playerid,WEISS,string);
		new query1[500];
		mysql_format(handle, query1, sizeof(query1), "SELECT * FROM `verwalter` WHERE `SpielerID` = '%d'", SpielerDaten[playerid][player_ID]);
		mysql_pquery(handle, query1, "OnVerwalterCheck", "d", playerid);
	}
	return 1;
}

Alles anzeigen

Code

public OnPlayerSpawn(playerid)
{
	print("1");
	if(IsPlayerConnected(playerid))
	{
		print("2");
		SetPlayerColor(playerid, WEISS);
		SetPlayerPos(playerid, SpielerDaten[playerid][player_Spawn][0], SpielerDaten[playerid][player_Spawn][1], SpielerDaten[playerid][player_Spawn][2]);
		SetPlayerFacingAngle(playerid, SpielerDaten[playerid][player_Spawn][3]);
		SetPlayerInterior(playerid, SpielerDaten[playerid][player_Interior]);
		SetPlayerVirtualWorld(playerid, SpielerDaten[playerid][player_World]);
		SetCameraBehindPlayer(playerid);
		SetPlayerSkin(playerid, SpielerDaten[playerid][player_Skin]);
		PlayerTextDrawShow(playerid,Geldanzeige[playerid][0]);
		PlayerTextDrawShow(playerid,Geldanzeige[playerid][1]);
		UpdateMoney(playerid);
		print("3");
	}
	return 1;
}

Alles anzeigen

Edit: Auf Windows funktoniert es, jedoch auf Linux nicht.

@Infra

Fehler in /admins

breadfish.de 12. März 2022

Ähnliche Themen

[SAMMELTHREAD] Kleine Scripting Fragen

Server stürzt ab (Fahrzeug Zulassung, MySqL)

Befehl Frage

Fahrzeug lackieren

Enter/Exits Error